Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-982481: Sync MacOS time #826

Merged
merged 1 commit into from
Dec 4, 2023
Merged

SNOW-982481: Sync MacOS time #826

merged 1 commit into from
Dec 4, 2023

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

Description

Sync MacOS time before running the tests.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner December 1, 2023 09:58
sfc-gh-pmotacki
sfc-gh-pmotacki approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Dec 1, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2dce725) 83.48% compared to head (f478dac) 83.41%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #826      +/-   ##
==========================================
- Coverage   83.48%   83.41%   -0.07%     
==========================================
  Files          89       89              
  Lines        9173     9173              
  Branches      839      839              
==========================================
- Hits         7658     7652       -6     
- Misses       1284     1290       +6     
  Partials      231      231

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pbulawa sfc-gh-pbulawa merged commit 614cd7d into master Dec 4, 2023
20 of 22 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the SNOW-982481-sync-time-macos branch December 4, 2023 09:11
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-pbulawa @sfc-gh-dprzybysz @sfc-gh-pmotacki